#4 Change the appearance of the zones tool

Fusionné
jmacura a fusionné 14 commits à partir de jmacura/better-gui vers jmacura/main il y a 3 ans
  • upgrade to HSLayers 9.2
  • replace date slider with calendar
  • reorder the layout of the tool
* upgrade to HSLayers 9.2 * replace date slider with calendar * reorder the layout of the tool
jmacura a commenté il y a 3 ans
Propriétaire

My comments:

  • were the new dependencies necessary? Won't they install manually?
  • Why changing translations from JSON to .ts file?
  • You have removed the indicator showing which field is selected. This was intentional?
  • The calendar stays in English even when the UI is in Czech. Is there some way to fix this?
  • I gonna do some styling of the code and reword the commits, ok?
  • I like the new spacious UI design :+1:
My comments: * were the new dependencies necessary? Won't they install manually? * Why changing translations from JSON to .ts file? * You have removed the indicator showing which field is selected. This was intentional? * The calendar stays in English even when the UI is in Czech. Is there some way to fix this? * I gonna do some styling of the code and reword the commits, ok? * I like the new spacious UI design :+1:
František Zadražil a commenté il y a 3 ans
Collaborateur
  • were the new dependencies necessary? Won't they install manually?

There was one additional dependency of npx-bootstrap that I intended to use for the calendar component, but at the end haven't used it. So this one was left there by mistake. I will remove it. The others are just new versions due to the Angular upgrade.

  • Why changing translations from JSON to .ts file?

I believe that was needed for the Angular upgrade. Translations haven't worked with JSON.

  • You have removed the indicator showing which field is selected. This was intentional?

We have switched to another LPIS layer to query features which did not have the ID attribute at that time. That is why I removed it. Now it could be returned as the layer was extended by the needed attributes.

  • The calendar stays in English even when the UI is in Czech. Is there some way to fix this?

I hope it is, but let's leave this for another issue dedicated to that. The calendar component is still not ideal, eg. it lets you select even days that have no data available.

  • I gonna do some styling of the code and reword the commits, ok?

As you wish. Just wait for my commits that will solve some of your comments.

* were the new dependencies necessary? Won't they install manually? There was one additional dependency of npx-bootstrap that I intended to use for the calendar component, but at the end haven't used it. So this one was left there by mistake. I will remove it. The others are just new versions due to the Angular upgrade. * Why changing translations from JSON to .ts file? I believe that was needed for the Angular upgrade. Translations haven't worked with JSON. * You have removed the indicator showing which field is selected. This was intentional? We have switched to another LPIS layer to query features which did not have the ID attribute at that time. That is why I removed it. Now it could be returned as the layer was extended by the needed attributes. * The calendar stays in English even when the UI is in Czech. Is there some way to fix this? I hope it is, but let's leave this for another issue dedicated to that. The calendar component is still not ideal, eg. it lets you select even days that have no data available. * I gonna do some styling of the code and reword the commits, ok? As you wish. Just wait for my commits that will solve some of your comments.
jmacura a commenté il y a 3 ans
Propriétaire

Great, thank you, merging!

Great, thank you, merging!
Cette Pull Request a été fusionnée avec succès !
Connectez-vous pour rejoindre cette conversation.
Aucun jalon
Pas d'assignataire
2 Participants
Chargement…
Annuler
Enregistrer
Il n'existe pas encore de contenu.