#4 Change the appearance of the zones tool

병합
jmacura jmacura/better-gui 에서 jmacura/main 로 14 commits 를 머지했습니다 3 년 전
  • upgrade to HSLayers 9.2
  • replace date slider with calendar
  • reorder the layout of the tool
* upgrade to HSLayers 9.2 * replace date slider with calendar * reorder the layout of the tool
jmacura 코멘트됨, 3 년 전
소유자

My comments:

  • were the new dependencies necessary? Won't they install manually?
  • Why changing translations from JSON to .ts file?
  • You have removed the indicator showing which field is selected. This was intentional?
  • The calendar stays in English even when the UI is in Czech. Is there some way to fix this?
  • I gonna do some styling of the code and reword the commits, ok?
  • I like the new spacious UI design :+1:
My comments: * were the new dependencies necessary? Won't they install manually? * Why changing translations from JSON to .ts file? * You have removed the indicator showing which field is selected. This was intentional? * The calendar stays in English even when the UI is in Czech. Is there some way to fix this? * I gonna do some styling of the code and reword the commits, ok? * I like the new spacious UI design :+1:
František Zadražil 코멘트됨, 3 년 전
협업자
  • were the new dependencies necessary? Won't they install manually?

There was one additional dependency of npx-bootstrap that I intended to use for the calendar component, but at the end haven't used it. So this one was left there by mistake. I will remove it. The others are just new versions due to the Angular upgrade.

  • Why changing translations from JSON to .ts file?

I believe that was needed for the Angular upgrade. Translations haven't worked with JSON.

  • You have removed the indicator showing which field is selected. This was intentional?

We have switched to another LPIS layer to query features which did not have the ID attribute at that time. That is why I removed it. Now it could be returned as the layer was extended by the needed attributes.

  • The calendar stays in English even when the UI is in Czech. Is there some way to fix this?

I hope it is, but let's leave this for another issue dedicated to that. The calendar component is still not ideal, eg. it lets you select even days that have no data available.

  • I gonna do some styling of the code and reword the commits, ok?

As you wish. Just wait for my commits that will solve some of your comments.

* were the new dependencies necessary? Won't they install manually? There was one additional dependency of npx-bootstrap that I intended to use for the calendar component, but at the end haven't used it. So this one was left there by mistake. I will remove it. The others are just new versions due to the Angular upgrade. * Why changing translations from JSON to .ts file? I believe that was needed for the Angular upgrade. Translations haven't worked with JSON. * You have removed the indicator showing which field is selected. This was intentional? We have switched to another LPIS layer to query features which did not have the ID attribute at that time. That is why I removed it. Now it could be returned as the layer was extended by the needed attributes. * The calendar stays in English even when the UI is in Czech. Is there some way to fix this? I hope it is, but let's leave this for another issue dedicated to that. The calendar component is still not ideal, eg. it lets you select even days that have no data available. * I gonna do some styling of the code and reword the commits, ok? As you wish. Just wait for my commits that will solve some of your comments.
jmacura 코멘트됨, 3 년 전
소유자

Great, thank you, merging!

Great, thank you, merging!
이 풀리퀘스트가 성공적으로 머지되었습니다!
로그인하여 이 대화에 참여
마일스톤 없음
담당자 없음
참여자 2명
로딩중...
취소
저장
아직 콘텐츠가 없습니다.